Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Utils.flip_svd/2 to flip_svd/2 inside Scholar.Decomposition.PCA #299

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Change Utils.flip_svd/2 to flip_svd/2 inside Scholar.Decomposition.PCA #299

merged 1 commit into from
Sep 4, 2024

Conversation

krstopro
Copy link
Member

@krstopro krstopro commented Sep 4, 2024 •
edited
Loading

Fixes a bug inside Scholar.Decomposition.PCA where Scholar.Decomposition.Utils.flip_svd/2 was used instead of flip_svd/2 from the same module.

Closes #298

@krstopro
Copy link
Member Author

krstopro commented Sep 4, 2024 •
edited
Loading

@josevalim This should resolve it. Could you run it again?

@josevalim
Copy link
Contributor

CI was failing and now it no longer fails, so we are all good :)

@krstopro
Copy link
Member Author

krstopro commented Sep 4, 2024

Yeah, unit tests were passing originally on my machine, but that is because I had Scholar.Decomposition.Utils as my first approach was to have a separate module for incremental PCA. I didn't bother looking at CI as it was taking way too long to finish (probably had something to do with CrowdStrike accident). Apologies for that.

@krstopro krstopro merged commit 2dca4aa into elixir-nx:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-terminating PCA decomposition
2 participants
@krstopro @josevalim